Add adaptive lighting#14877
Conversation
|
Should this be a featured integration, so people can find out about it more easily? |
|
Whats the difference to the already existing one? :-) https://www.home-assistant.io/integrations/flux/ |
|
It has more advanced config, UI configuration, and is based on top of the most popular component on HACS with 231 (!) stars. So I guess it's better... |
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
mountainsandcode
left a comment
There was a problem hiding this comment.
Sunrise_time is mentioned twice, sunset_time is missing
mountainsandcode
left a comment
There was a problem hiding this comment.
@KTibow I noticed these parameters are declared optional in services descriptions - so suggestions below. May make sense to check all of the other services, too, so that they are aligned.
| | Service data attribute | Optional | Description | | ||
| |------------------------|----------|--------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `entity_id` | no | The `entity_id` of the switch in which to (un)mark the light as being "manually controlled". | | ||
| | `lights` | no | A light (or list of lights) to apply the settings to. | |
There was a problem hiding this comment.
| | `lights` | no | A light (or list of lights) to apply the settings to. | | |
| | `lights` | Yes | A light (or list of lights) to apply the settings to. Default: All lights in the switch. | |
| |------------------------|----------|--------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `entity_id` | no | The `entity_id` of the switch in which to (un)mark the light as being "manually controlled". | | ||
| | `lights` | no | A light (or list of lights) to apply the settings to. | | ||
| | `manual_control` | no | Whether to mark (true) or unmark (false) the light as "manually controlled", when not specified it selects all lights in the switch. | |
There was a problem hiding this comment.
| | `manual_control` | no | Whether to mark (true) or unmark (false) the light as "manually controlled", when not specified it selects all lights in the switch. | | |
| | `manual_control` | yes | Whether to mark (true) or unmark (false) the light as "manually controlled", when not specified it selects all lights in the switch. Default: true | |
There was a problem hiding this comment.
Couldn't we add another column for defaults?
There was a problem hiding this comment.
Also on your next one, drag the plus button to suggest changes to multiple lines at once.
Co-authored-by: mountainsandcode <mountainsandcode@icloud.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
Co-authored-by: Bas Nijholt <basnijholt@gmail.com>
|
Damn what a lot of changes 😅 |
|
In terms of commits, or line numbers, on the docs PR or on the code PR? Yes, it's big. |
|
Closing PR as the parent PR has been closed. |



Proposed change
This adds docs for the new adaptive lighting component.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.