Update Monoprice docs to reflect recent changes#13262
Merged
Merged
Conversation
Member
|
@OnFreund This PR depends on multiple parents? So now one has merged... And we should do what? Please separate each documentation change to match one parent PR. Thanks 👍 |
Contributor
Author
|
This was originally a single backend PR but I was encouraged to split it up. Is it ok if I turn this into a draft and change back once the second PR is merged? |
Member
|
Well, @OnFreund, the problem is, we are less than 24 hours away from the beta cut. There is now a change in our main codebase that is documented in this PR. But there is also a change documented in this PR that is not in our codebase. Please reduce this PR to match the merged parent PR and create a new one for the other parent PR that is still open. |
Of the two PRs covered by this chance to docs, one didn't make it quite yet. Restoring the previous state for now.
Contributor
Author
|
@frenck done |
frenck
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
No need to use spaces instead of source names anymore.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.