Skip to content

Update Monoprice docs to reflect recent changes#13262

Merged
frenck merged 2 commits into
home-assistant:nextfrom
OnFreund:patch-3
May 12, 2020
Merged

Update Monoprice docs to reflect recent changes#13262
frenck merged 2 commits into
home-assistant:nextfrom
OnFreund:patch-3

Conversation

@OnFreund
Copy link
Copy Markdown
Contributor

@OnFreund OnFreund commented May 2, 2020

Proposed change

No need to use spaces instead of source names anymore.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@frenck
Copy link
Copy Markdown
Member

frenck commented May 3, 2020

@OnFreund This PR depends on multiple parents?

So now one has merged... And we should do what?

Please separate each documentation change to match one parent PR.

Thanks 👍

@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 3, 2020
@OnFreund
Copy link
Copy Markdown
Contributor Author

OnFreund commented May 3, 2020

This was originally a single backend PR but I was encouraged to split it up. Is it ok if I turn this into a draft and change back once the second PR is merged?

@OnFreund OnFreund marked this pull request as draft May 3, 2020 19:49
@frenck frenck self-assigned this May 8, 2020
@frenck
Copy link
Copy Markdown
Member

frenck commented May 12, 2020

Well, @OnFreund, the problem is, we are less than 24 hours away from the beta cut. There is now a change in our main codebase that is documented in this PR. But there is also a change documented in this PR that is not in our codebase.

Please reduce this PR to match the merged parent PR and create a new one for the other parent PR that is still open.

Of the two PRs covered by this chance to docs, one didn't make it quite yet. Restoring the previous state for now.
@OnFreund
Copy link
Copy Markdown
Contributor Author

@frenck done

@frenck frenck added the parent-merged The parent PR has been merged already label May 12, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @OnFreund 👍

@frenck frenck marked this pull request as ready for review May 12, 2020 07:43
@frenck frenck removed their assignment May 12, 2020
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed in-progress This PR/Issue is currently being worked on labels May 12, 2020
@frenck frenck merged commit bceb343 into home-assistant:next May 12, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label May 12, 2020
@OnFreund OnFreund deleted the patch-3 branch May 12, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants