Skip to content

Try to automatically detect zones on first run of Monoprice integration#35127

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
OnFreund:monoprice_detect_zones
May 12, 2020
Merged

Try to automatically detect zones on first run of Monoprice integration#35127
MartinHjelmare merged 1 commit intohome-assistant:devfrom
OnFreund:monoprice_detect_zones

Conversation

@OnFreund
Copy link
Copy Markdown
Contributor

@OnFreund OnFreund commented May 3, 2020

Proposed change

Try to automatically detect zones on first run, by checking for failures. A failed extension zone (21..26, 31..36), will be enabled if update() succeeded, and disabled if it failed. Zones 11..16 will be enabled regardless.

After the first run, don't call update() before adding to the entity registry on subsequent runs, to speed boot up and avoid warnings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link
Copy Markdown

Hey there @etsinko, mind taking a look at this pull request as its been labeled with a integration (monoprice) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@OnFreund
Copy link
Copy Markdown
Contributor Author

OnFreund commented May 12, 2020

Is there any way to move this to "Needs Review" instead of "By Code Owner"? I don't think @etsinko is active anymore.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 3fcd786 into home-assistant:dev May 12, 2020
@OnFreund OnFreund deleted the monoprice_detect_zones branch May 13, 2020 04:35
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants