Try to automatically detect zones on first run of Monoprice integration#35127
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom May 12, 2020
Merged
Conversation
This was referenced May 3, 2020
8 tasks
Contributor
Author
|
Is there any way to move this to "Needs Review" instead of "By Code Owner"? I don't think @etsinko is active anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Try to automatically detect zones on first run, by checking for failures. A failed extension zone (21..26, 31..36), will be enabled if
update()succeeded, and disabled if it failed. Zones 11..16 will be enabled regardless.After the first run, don't call update() before adding to the entity registry on subsequent runs, to speed boot up and avoid warnings.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: