Some small Monoprice fixes#35064
Closed
OnFreund wants to merge 4 commits intohome-assistant:devfrom
Closed
Conversation
8 tasks
Member
|
If you split this PR into five PRs reviews will be faster. |
Contributor
Author
|
@MartinHjelmare thanks. I understand and appreciate the logic - but most of these are either really small (1, 2, code owners), or related (3 & 4 go together). Is it worth the extra pipelines, etc? If it is, I'll split it up a bit. |
Member
|
It's always worth it to make PRs smaller. Smaller PRs skip the line. Smaller PRs are easier to review so less risk of bugs. Smaller PRs have less things to talk about so the review iteration will be shorter. |
Contributor
Author
|
OK, here's the first small PR in this series: #35107 |
Contributor
Author
Contributor
Author
|
The final PR: |
Contributor
Author
|
Since this is all covered by smaller PRs now, and only one of those hasn't been merged yet, I'm closing this, in hope that #35127 gets reviewed and merged soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
update()before adding to the entity registry on subsequent runs, to speed boot up and avoid warnings.Also added myself as a codeowner since over the past few weeks I've basically re-written it.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: