Skip to content

Add timeout parameter#13236

Closed
benleb wants to merge 2 commits into
home-assistant:nextfrom
benleb:add-timeout-parameter
Closed

Add timeout parameter#13236
benleb wants to merge 2 commits into
home-assistant:nextfrom
benleb:add-timeout-parameter

Conversation

@benleb
Copy link
Copy Markdown
Contributor

@benleb benleb commented Apr 30, 2020

Proposed change

add timeout parameter

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Apr 30, 2020
Copy link
Copy Markdown
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged 👍

@klaasnicolaas klaasnicolaas added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels Apr 30, 2020
@benleb
Copy link
Copy Markdown
Contributor Author

benleb commented May 3, 2020

Closing as the new parameter was removed and just a new default value is set in the parent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants