Skip to content

add timeout parameter to surepetcare integration#13235

Closed
benleb wants to merge 2 commits intohome-assistant:currentfrom
benleb:upgrade-surepy
Closed

add timeout parameter to surepetcare integration#13235
benleb wants to merge 2 commits intohome-assistant:currentfrom
benleb:upgrade-surepy

Conversation

@benleb
Copy link
Copy Markdown
Contributor

@benleb benleb commented Apr 30, 2020

Proposed change

add timeout parameter

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 30, 2020
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 30, 2020
@klaasnicolaas
Copy link
Copy Markdown
Member

This PR should go into the next branch, change the target branch and rebase if necessary.

@benleb
Copy link
Copy Markdown
Contributor Author

benleb commented Apr 30, 2020

i do not really agree, but i also do not care :D #13236

@benleb benleb closed this Apr 30, 2020
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Apr 30, 2020
@klaasnicolaas
Copy link
Copy Markdown
Member

Why you don't agree?

The docs always reflect what is in the code (core repo). The changes in this PR are not yet applicable since your parent PR in the core repo has not been merged. In other words, if something changes in the core, your PRs here always belong in the next branch.

If you make changes to the existing docs, because something is wrong or an addition for which the code does not have to be changed, then you PR belongs to the current branch.

Kind of strange if we're going to add something to the docs if it doesn't exist in the code yet right? 😉

@benleb
Copy link
Copy Markdown
Contributor Author

benleb commented Apr 30, 2020

Ah sorry, little misunderstanding of current/next on my side 😄✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants