Skip to content

Increase surepetcare default timeout#34944

Merged
MartinHjelmare merged 5 commits intohome-assistant:devfrom
benleb:upgrade-surepy
May 3, 2020
Merged

Increase surepetcare default timeout#34944
MartinHjelmare merged 5 commits intohome-assistant:devfrom
benleb:upgrade-surepy

Conversation

@benleb
Copy link
Copy Markdown
Contributor

@benleb benleb commented Apr 30, 2020

Proposed change

add timeout parameter and increase default timeout

Type of change

add timeout parameter and increase default timeout to fix issues mentioned below

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
surepetcare:
  username: YOUR_SURE_PETCARE_LOGIN
  password: YOUR_SURE_PETCARE_PASSWORD
  feeders: [12345, 67890]
  flaps: [13579]
  pets: [24680]

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title add timeout parameter and increase default timeout Add surepetcare timeout parameter and increase default timeout Apr 30, 2020
Comment thread homeassistant/components/surepetcare/binary_sensor.py Outdated
Comment thread homeassistant/components/surepetcare/__init__.py Outdated
@benleb
Copy link
Copy Markdown
Contributor Author

benleb commented May 3, 2020

Thanks @MartinHjelmare 👍

@benleb benleb changed the title Add surepetcare timeout parameter and increase default timeout Increase surepetcare default timeout May 3, 2020
@benleb benleb requested a review from MartinHjelmare May 3, 2020 09:07
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit d644b61 into home-assistant:dev May 3, 2020
@benleb benleb deleted the upgrade-surepy branch May 3, 2020 13:56
@lock lock Bot locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sure Petcare fails to reconnect or setup when server is temporarily unavailable surepetcare integration failing to start

3 participants