Convert Nextcloud integration to use Brand media#12571
Closed
meichthys wants to merge 11 commits into
Closed
Conversation
Bring fork up to date
frenck
requested changes
Mar 31, 2020
Member
frenck
left a comment
There was a problem hiding this comment.
There are unrelated commits in this PR. Could you please clean that up? Thanks 👍
Contributor
Author
Member
|
@meichthys The problem is you didn't create a new branch or your fork. You should create a new branch each time you start working on something new. |
Contributor
Author
|
Ok, Thanks for tolerating us noobs :) |
Member
|
That is probably the fastest thing to do :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Removes the explicit reference to logo in favor of using the images in the Brand repository.
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.