Skip to content

Convert Nextcloud integration to use Brand media#12571

Closed
meichthys wants to merge 11 commits into
home-assistant:nextfrom
meichthys:next
Closed

Convert Nextcloud integration to use Brand media#12571
meichthys wants to merge 11 commits into
home-assistant:nextfrom
meichthys:next

Conversation

@meichthys
Copy link
Copy Markdown
Contributor

Proposed change

Removes the explicit reference to logo in favor of using the images in the Brand repository.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • I've opened up a PR to add logo's and icons in Brands repository.
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 31, 2020
@frenck frenck added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Mar 31, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unrelated commits in this PR. Could you please clean that up? Thanks 👍

@meichthys
Copy link
Copy Markdown
Contributor Author

@frenck I'm not sure what happened here. Those other commits are old commits that i thought were already merged in #11780
I'm not sure how to clean this up :/

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 31, 2020

@meichthys The problem is you didn't create a new branch or your fork. You should create a new branch each time you start working on something new.

@meichthys
Copy link
Copy Markdown
Contributor Author

Ok, Thanks for tolerating us noobs :)
Should i close this pull request and submit a new one on a new branch?

Copy link
Copy Markdown
Member

frenck commented Mar 31, 2020

That is probably the fastest thing to do :)

@meichthys meichthys closed this Mar 31, 2020
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants