Skip to content

Nextcloud Integration#11780

Merged
frenck merged 9 commits into
home-assistant:nextfrom
meichthys:next
Mar 24, 2020
Merged

Nextcloud Integration#11780
frenck merged 9 commits into
home-assistant:nextfrom
meichthys:next

Conversation

@meichthys
Copy link
Copy Markdown
Contributor

@meichthys meichthys commented Jan 17, 2020

Description:
This pull request provides documentation for the new nextcloud integration.

Pull request in home-assistant (if applicable): home-assistant/core#30871

Checklist:

  • [ x] Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • [x ] The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Jan 17, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Jan 17, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Jan 20, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @meichthys!

I've reviewed it, and left some comments. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/nextcloud.markdown Outdated
Comment thread source/_integrations/nextcloud.markdown Outdated
Comment thread source/_integrations/nextcloud.markdown Outdated
Comment thread source/_integrations/nextcloud.markdown Outdated
Comment thread source/_integrations/nextcloud.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 20, 2020
@meichthys meichthys requested a review from frenck January 20, 2020 19:09
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Jan 20, 2020
frenck
frenck previously approved these changes Jan 20, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 20, 2020
Comment thread source/_integrations/nextcloud.markdown
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Mar 24, 2020
@frenck frenck merged commit 1cdd2f2 into home-assistant:next Mar 24, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Mar 24, 2020
@meichthys
Copy link
Copy Markdown
Contributor Author

Thanks @frenck !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants