Skip to content

Add Nextcloud Integration#30871

Merged
MartinHjelmare merged 46 commits into
home-assistant:devfrom
meichthys:dev
Mar 24, 2020
Merged

Add Nextcloud Integration#30871
MartinHjelmare merged 46 commits into
home-assistant:devfrom
meichthys:dev

Conversation

@meichthys
Copy link
Copy Markdown
Contributor

Breaking Change:

None!

Description:

This integration pulls Nextcloud summary information into home-assistant using the Nextcloud provided Monitor api.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11780

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
sensor:
  - platform: nextcloud
    url: HTTPS://YOUR_NEXTCLOUD_URL
    username: YOUR_USERNAME
    password: YOUR_APP_PASSWORD

Checklist:

  • [x ] The code change is tested and works locally.
  • [ n/a] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • [ x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • [ x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • [ x] Tests have been added to verify that the new code works.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @meichthys,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@springstan
Copy link
Copy Markdown
Member

Please update the CODEOWNERS file by running python3 -m script.hassfest to fix the validate error.

@meichthys
Copy link
Copy Markdown
Contributor Author

python3 -m script.hassfest

Ok, Thanks. Done!

@meichthys meichthys requested review from balloob and frenck January 18, 2020 00:22
@Shulyaka
Copy link
Copy Markdown
Contributor

You probably need to add some tests into tests/components/nextcloud/

@springstan
Copy link
Copy Markdown
Member

Please run python3 -m script.gen_requirements_all to fix the failing validate check.

@meichthys
Copy link
Copy Markdown
Contributor Author

@springstan I ran python3 -m script.gen_requirements_all already. Is there still something missing?

@springstan
Copy link
Copy Markdown
Member

I completely misread #30871 (comment) you need to add tests otherwise no tests are found to examine the code coverage.

@springstan springstan changed the title Nextcloud Integration Add Nextcloud Integration Jan 18, 2020
@meichthys meichthys requested a review from springstan January 19, 2020 03:14
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
@meichthys
Copy link
Copy Markdown
Contributor Author

@springstan Thanks for the review! I'll work on these suggestions.

@meichthys meichthys requested a review from springstan February 7, 2020 03:01
Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meichthys could you please take a look at my suggestions? A lot of them have not been resolved yet.

@meichthys
Copy link
Copy Markdown
Contributor Author

@springstan Could you look at db98f7d ? I think that has some of the changes you requested.

@springstan
Copy link
Copy Markdown
Member

@meichthys of course somehow I did not see them at first.

Copy link
Copy Markdown
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meichthys thanks for implementing my suggested changes! Looks better now 👍

Comment thread homeassistant/components/nextcloud/sensor.py Outdated
@meichthys
Copy link
Copy Markdown
Contributor Author

grr. I'll push the change when i get home to my main dev environment.

@codecov

This comment has been minimized.

@meichthys meichthys requested a review from springstan February 8, 2020 02:48
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
Comment thread homeassistant/components/nextcloud/binary_sensor.py
Comment thread homeassistant/components/nextcloud/sensor.py
Comment thread homeassistant/components/nextcloud/__init__.py Outdated
Comment thread homeassistant/components/nextcloud/binary_sensor.py Outdated
Comment thread homeassistant/components/nextcloud/sensor.py
Comment thread homeassistant/components/nextcloud/sensor.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

There's a merge conflict.

@meichthys
Copy link
Copy Markdown
Contributor Author

meichthys commented Mar 23, 2020

There's a merge conflict.

I'll push an update to fix the unique_id and the requirements_all.txt when i get home this evening.
I believe those are the only two outstanding items to finish before this can be merged?

On a side note i was looking for a 0.108 deadline but the calendar seems to be blank. Do you know when the deadline is?
image

Comment thread homeassistant/components/nextcloud/__init__.py Outdated
@MartinHjelmare
Copy link
Copy Markdown
Member

The beta cut for new features is in 1.5 weeks. The release one week after that. Always on Wednesdays.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 3c59791 into home-assistant:dev Mar 24, 2020
@meichthys
Copy link
Copy Markdown
Contributor Author

Looks good!

@MartinHjelmare and @springstan
Thanks for all your help on this and for your patience!

@lock lock Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants