Add Nextcloud Integration#30871
Conversation
|
Hi @meichthys, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Please update the CODEOWNERS file by running |
Ok, Thanks. Done! |
|
You probably need to add some tests into |
|
Please run |
|
@springstan I ran |
|
I completely misread #30871 (comment) you need to add tests otherwise no tests are found to examine the code coverage. |
|
@springstan Thanks for the review! I'll work on these suggestions. |
springstan
left a comment
There was a problem hiding this comment.
@meichthys could you please take a look at my suggestions? A lot of them have not been resolved yet.
|
@springstan Could you look at db98f7d ? I think that has some of the changes you requested. |
|
@meichthys of course somehow I did not see them at first. |
springstan
left a comment
There was a problem hiding this comment.
@meichthys thanks for implementing my suggested changes! Looks better now 👍
|
grr. I'll push the change when i get home to my main dev environment. |
This comment has been minimized.
This comment has been minimized.
|
There's a merge conflict. |
|
The beta cut for new features is in 1.5 weeks. The release one week after that. Always on Wednesdays. |
@MartinHjelmare and @springstan |

Breaking Change:
None!
Description:
This integration pulls Nextcloud summary information into home-assistant using the Nextcloud provided Monitor api.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11780
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: