Skip to content

Add cover to Dynalite integration#12275

Merged
frenck merged 10 commits into
home-assistant:nextfrom
ziv1234:patch-4
Apr 3, 2020
Merged

Add cover to Dynalite integration#12275
frenck merged 10 commits into
home-assistant:nextfrom
ziv1234:patch-4

Conversation

@ziv1234
Copy link
Copy Markdown
Contributor

@ziv1234 ziv1234 commented Mar 5, 2020 •
edited
Loading

Proposed change

Adds the support for covers for Dynalite
Also adds the definitions of room presets: timecover, room, and trigger

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Mar 5, 2020
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Mar 5, 2020
@ziv1234 ziv1234 mentioned this pull request Mar 5, 2020
Closed
20 tasks
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 6, 2020
@klaasnicolaas klaasnicolaas changed the title Update dynalite.markdown Add cover to Dynalite integration Mar 6, 2020
frenck
frenck requested changes Mar 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ziv1234!

Left some small review suggestions. Could you please take a look? Thanks! 👍

Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
Comment thread source/_integrations/dynalite.markdown Outdated
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 6, 2020
ziv1234 and others added 5 commits March 6, 2020 15:29
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
62c4d49 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
39937dd 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
796ad87 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
adb4e7b 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234 @frenck
Update source/_integrations/dynalite.markdown
af9870f 
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 6, 2020

Thanks for the PR @ziv1234!

Left some small review suggestions. Could you please take a look? Thanks! 👍

Thanks!

frenck
frenck previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Mar 6, 2020
@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 6, 2020
@ziv1234 ziv1234 mentioned this pull request Mar 8, 2020
Merged
20 tasks
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 9, 2020

i changed the code PR since i messed up some stuff with rebasing. Same code / PR, just a new number

frenck
frenck previously approved these changes Mar 10, 2020
View reviewed changes
klaasnicolaas
klaasnicolaas previously approved these changes Mar 11, 2020
View reviewed changes
@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Mar 11, 2020

We have a little merge conflict

@ziv1234 ziv1234 dismissed stale reviews from klaasnicolaas and frenck via 4bdc5f3 March 11, 2020 13:38
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 11, 2020

I believe I just fixed it. Two adjacent lines added but both are relevant so it caused a conflict

@frenck frenck added the parent-merged The parent PR has been merged already label Apr 2, 2020
frenck
frenck approved these changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ziv1234! 👍

@frenck frenck merged commit e3645d8 into home-assistant:next Apr 3, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

@klaasnicolaas klaasnicolaas klaasnicolaas left review comments

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ziv1234 @klaasnicolaas @frenck