Skip to content

Add Dynalite cover#32511

Closed
ziv1234 wants to merge 0 commit intohome-assistant:devfrom
ziv1234:dynalite_cover
Closed

Add Dynalite cover#32511
ziv1234 wants to merge 0 commit intohome-assistant:devfrom
ziv1234:dynalite_cover

Conversation

@ziv1234
Copy link
Copy Markdown
Contributor

@ziv1234 ziv1234 commented Mar 5, 2020

Breaking change

Not a breaking change

Proposed change

Adding the cover platform to Dynalite

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
bridges:
    - host: 10.0.0.200
      port: 95
      autodiscover: false
      polltimer: 1
      active: off
      # log_level: debug
      area:
        '9':
          name: Office
          channel:
            '1': 
              name: Center
            '2': 
              name: East
              fade: 2
            '3': 
              name: West
        '10':
          name: Cinema
          template: room
          channel:
            '1':
              name: Spot
            '2':
              name: Wall
            '3':
              name: Wall Plug
        '108':
          name: Office Blind
          template: timecover
          tilt: 3
          duration: 75

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 8, 2020

i tried to rebase since build was failing on tests that don't seem related to me. However, I followed the same instructions that I used in the past and it seems like I have all the commit from dev here. Should I cancel this one and open a new PR?

@ziv1234 ziv1234 closed this Mar 8, 2020
@ziv1234
Copy link
Copy Markdown
Contributor Author

ziv1234 commented Mar 8, 2020

ok. tried to fix it and i think it messed up things even more. Will open a new branch

@ziv1234 ziv1234 mentioned this pull request Mar 8, 2020
20 tasks
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants