Add cover platform to Dynalite#32594
Conversation
163f415 to
2d4e522
Compare
|
just checking in now that 107 is out. Is there something I should do to get a review or should I just wait? This is a very minor fix in code (adding cover.py) but also has some refactoring of the tests to remove redundant code. |
9660420 to
18b9d9f
Compare
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
corrected type hints - not clear why mypy didn't catch it
removed leftover log
changed "channelcover" to "channel_cover"
|
Thanks! For some reason there are tests failing in the CI that don't seem related (dyson component, the next one in alphabetical order...). Could this be related to the PR? They all pass in my venv |
|
I don't see any dyson tests failing, just tts and they are expected currently. |
|
thanks! Maybe i got mixed up with something. appreciate everything |
|
I'm not sure. Ask in the discord dev chat or architecture issue. |
|
thanks. I will make the PR at some point in any case, so it can be reviewed. already have the code so now just copy/paste... |
Breaking change
Not a breaking change
Proposed change
Adding the cover platform to Dynalite. This is reimplemented from #32511 because I did something wrong with the rebase
Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: