Skip to content

Plex add media_player server config#10303

Merged
frenck merged 6 commits into
home-assistant:nextfrom
jjlawren:plex_add_mp_server_config
Sep 10, 2019
Merged

Plex add media_player server config#10303
frenck merged 6 commits into
home-assistant:nextfrom
jjlawren:plex_add_mp_server_config

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 7, 2019

Description:
Allows configuration of the Plex media_player platform via config in addition to the nonstandard plex.conf file. Dependent on open PR #10297.

Pull request in home-assistant (if applicable): home-assistant/core#26458

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 7, 2019
DubhAd
DubhAd previously approved these changes Sep 7, 2019
Copy link
Copy Markdown
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DubhAd DubhAd added the awaits-parent Awaits the merge of an parent PR label Sep 7, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @jjlawren, I've reviewed your PR and left some comments. Could you please take a look? Thanks!

Comment thread source/_components/plex.markdown Outdated
Comment thread source/_components/plex.markdown Outdated
@frenck frenck added in-progress This PR/Issue is currently being worked on and removed awaits-parent Awaits the merge of an parent PR labels Sep 7, 2019
@jjlawren
Copy link
Copy Markdown
Contributor Author

jjlawren commented Sep 9, 2019

Updated. Can #10297 please be merged before this?

@frenck frenck added the parent-merged The parent PR has been merged already label Sep 10, 2019
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready to merge 🎉

@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Sep 10, 2019
@frenck frenck merged commit 87ed2c0 into home-assistant:next Sep 10, 2019
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 10, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
@jjlawren jjlawren deleted the plex_add_mp_server_config branch May 8, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants