Skip to content

Add documentation for Jandy iAqualink component.#10165

Merged
frenck merged 6 commits into
home-assistant:nextfrom
flz:iaqualink
Sep 10, 2019
Merged

Add documentation for Jandy iAqualink component.#10165
frenck merged 6 commits into
home-assistant:nextfrom
flz:iaqualink

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented Aug 18, 2019 •
edited by frenck
Loading

Description:

The iaqualink component adds support for Jandy pool control systems and exposes thermostats, lights, sensors and switches.

Pull request in home-assistant (if applicable):

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Aug 18, 2019
@flz
Copy link
Copy Markdown
Contributor Author

flz commented Aug 18, 2019

Pull request for the actual component will be submitted in a few minutes.

@flz flz mentioned this pull request Aug 18, 2019
Merged
7 tasks
@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Aug 18, 2019
klaasnicolaas
klaasnicolaas previously requested changes Aug 18, 2019
View reviewed changes
Comment thread source/_components/iaqualink.markdown Outdated
@flz @klaasnicolaas
Update source/_components/iaqualink.markdown
7a1a6ae 
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration ready-for-review This PR needs to be reviewed labels Aug 21, 2019
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Sep 6, 2019
MartinHjelmare
MartinHjelmare previously requested changes Sep 6, 2019
View reviewed changes
Comment thread source/_components/iaqualink.markdown Outdated
Comment thread source/_components/iaqualink.markdown
Comment thread source/_components/iaqualink.markdown
Comment thread source/_components/iaqualink.markdown Outdated
Comment thread source/_components/iaqualink.markdown Outdated
Comment thread source/_components/iaqualink.markdown Outdated
@flz flz mentioned this pull request Sep 6, 2019
Merged
9 tasks
@flz @MartinHjelmare
Bump ha_release.
6b6862d 
Co-Authored-By: Martin Hjelmare <marhje52@kth.se>
@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 6, 2019

Re: climate-only: What's the grace period to get this documentation landed? I have all the other platforms ready to review (light platform PR has been submitted already) but they can't all be merged at the same time given that the patched need to be applied in order. I was hoping all platforms would make it to 0.99.

@MartinHjelmare
Copy link
Copy Markdown
Member

MartinHjelmare commented Sep 6, 2019

I'll let the docs team respond.

@frenck
Copy link
Copy Markdown
Member

frenck commented Sep 9, 2019

⚠️ This cannot be merged since this PR has multiple parent PR's (and not all are merged).

@flz Please split the documentation PR's to match the parent PR's.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 9, 2019

@flz Please split the documentation PR's to match the parent PR's.

I've removed mentions of sensor/switch platforms.

I've left the light platform mentions since the PR is ready for landing (home-assistant/core#26484).

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 9, 2019

@frenck Should be good to go now!

@flz flz mentioned this pull request Sep 9, 2019
Merged
9 tasks
frenck
frenck approved these changes Sep 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @flz! 👍
Let's merge this in! 🎉

@frenck frenck dismissed stale reviews from MartinHjelmare and klaasnicolaas September 10, 2019 19:14

Comments addressed.

@frenck frenck merged commit 733ad41 into home-assistant:next Sep 10, 2019
@probot-home-assistant probot-home-assistant Bot removed ready-for-review This PR needs to be reviewed parent-merged The parent PR has been merged already labels Sep 10, 2019
@flz flz deleted the iaqualink branch September 10, 2019 20:19
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@klaasnicolaas klaasnicolaas klaasnicolaas left review comments

Assignees

No one assigned

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flz @MartinHjelmare @frenck @klaasnicolaas