Skip to content

Add new integration for Jandy iAqualink pool control#26034

Merged
MartinHjelmare merged 4 commits into
home-assistant:devfrom
flz:iaqualink
Sep 6, 2019
Merged

Add new integration for Jandy iAqualink pool control#26034
MartinHjelmare merged 4 commits into
home-assistant:devfrom
flz:iaqualink

Conversation

@flz
Copy link
Copy Markdown
Contributor

@flz flz commented Aug 18, 2019

Description:

This is a new component introducing support for Jandy iAqualink pool controls.

This PR includes support for the climate platform only.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10165

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@flz flz requested a review from a team August 18, 2019 02:27
@flz flz requested a review from a team as a code owner August 18, 2019 02:27
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @flz,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Aug 18, 2019

Ugh. This shouldn't try to push 56 commits.

@flz flz changed the title Add support for Jandy iAqualink pool controls Add new integrations for Jandy iAqualink pool control Aug 18, 2019
@flz flz changed the title Add new integrations for Jandy iAqualink pool control Add new integration for Jandy iAqualink pool control Aug 18, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please start by removing the light, sensor and switch platforms from this PR. More platforms can come in later PRs, one platform per PR. We want PRs as small as possible for quicker merge.

Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/config_flow.py Outdated
Comment thread homeassistant/components/iaqualink/config_flow.py Outdated
Comment thread homeassistant/components/iaqualink/config_flow.py Outdated
Comment thread homeassistant/components/iaqualink/manifest.json Outdated
Comment thread .coveragerc Outdated
@flz
Copy link
Copy Markdown
Contributor Author

flz commented Aug 31, 2019

Thanks for the review.

Please update the documentation to reflect that new integrations shouldn't contain more than a single platform for the reasons you mention. I understand the goal of making PR somewhat self-contained but in the case of a new integration, this seems rather arbitrary, especially when undocumented.

@andrewsayre
Copy link
Copy Markdown
Member

Please update the documentation to reflect that new integrations shouldn't contain more than a single platform for the reasons you mention.

The docs do indicate that, but please let us know how we could make it more clear -- or better yet, submit a PR to the docs themselves with your improvements. :)

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 1, 2019

Apologies, the documentation is clear. I obviously have missed it!

@flz flz force-pushed the iaqualink branch 2 times, most recently from 46cb3db to cf5ff34 Compare September 2, 2019 01:25
@MartinHjelmare
Copy link
Copy Markdown
Member

Please don't squash commits after review has started to make it easier for readers to track changes.

@flz flz changed the title Add new integration for Jandy iAqualink pool control [1/4] Add new integration for Jandy iAqualink pool control with climate platform Sep 2, 2019
@flz flz changed the title [1/4] Add new integration for Jandy iAqualink pool control with climate platform Add new integration for Jandy iAqualink pool control Sep 2, 2019
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/__init__.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/climate.py Outdated
Comment thread homeassistant/components/iaqualink/config_flow.py Outdated
Comment thread tests/components/iaqualink/test_config_flow.py Outdated
Comment thread tests/components/iaqualink/test_config_flow.py Outdated
Comment thread tests/components/iaqualink/test_config_flow.py Outdated
Comment thread tests/components/iaqualink/test_config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when build passes.

@flz
Copy link
Copy Markdown
Contributor Author

flz commented Sep 3, 2019

Neat, thanks again for the help!

@MartinHjelmare MartinHjelmare merged commit 0abb2f3 into home-assistant:dev Sep 6, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 7, 2019
@flz flz deleted the iaqualink branch September 8, 2019 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants