Add new integration for Jandy iAqualink pool control#26034
Conversation
|
Ugh. This shouldn't try to push 56 commits. |
3f513e7 to
5c67af1
Compare
MartinHjelmare
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please start by removing the light, sensor and switch platforms from this PR. More platforms can come in later PRs, one platform per PR. We want PRs as small as possible for quicker merge.
|
Thanks for the review. Please update the documentation to reflect that new integrations shouldn't contain more than a single platform for the reasons you mention. I understand the goal of making PR somewhat self-contained but in the case of a new integration, this seems rather arbitrary, especially when undocumented. |
The docs do indicate that, but please let us know how we could make it more clear -- or better yet, submit a PR to the docs themselves with your improvements. :) |
|
Apologies, the documentation is clear. I obviously have missed it! |
46cb3db to
cf5ff34
Compare
|
Please don't squash commits after review has started to make it easier for readers to track changes. |
|
Can be merged when build passes. |
|
Neat, thanks again for the help! |
Description:
This is a new component introducing support for Jandy iAqualink pool controls.
This PR includes support for the climate platform only.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10165
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.