Skip to content

"Add Card", "Add Dashboard" labels for floating action buttons#7612

Closed
adamjernst wants to merge 1 commit intohome-assistant:devfrom
adamjernst:dashboard
Closed

"Add Card", "Add Dashboard" labels for floating action buttons#7612
adamjernst wants to merge 1 commit intohome-assistant:devfrom
adamjernst:dashboard

Conversation

@adamjernst
Copy link
Contributor

@adamjernst adamjernst commented Nov 6, 2020

Similar to #7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that.

This is especially important for "Add Card" in my opinion since there are two "+" buttons on that screen - one to add a view, and one to add a card.

Proposed change

Labels for floating action buttons.

add_dash

add-card

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@adamjernst adamjernst force-pushed the dashboard branch 3 times, most recently from 4fccc13 to 3c96e86 Compare November 6, 2020 16:22
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that.

This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
@adamjernst adamjernst closed this Nov 7, 2020
@adamjernst adamjernst deleted the dashboard branch November 7, 2020 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants