Ensure all <mwc-fab> set a label for ARIA#7587
Merged
bramkragten merged 4 commits intohome-assistant:devfrom Nov 7, 2020
Merged
Ensure all <mwc-fab> set a label for ARIA#7587bramkragten merged 4 commits intohome-assistant:devfrom
bramkragten merged 4 commits intohome-assistant:devfrom
Conversation
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts
Outdated
Show resolved
Hide resolved
Member
|
When you set a dynamic value (like a translation) use the property (with the |
Member
Author
|
@adamjernst FYI: I combined your proposed changes from #7612 into this PR since I anyway touched basically all |
Contributor
Beautiful, thanks! I'll close my PRs as soon as this is merged. |
bramkragten
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
<mwc-fab>uses thelabelattribute to set thearia-labelfor its included elements (= the actual button). This PR ensure that we set it for all<mwc-fab>.https://npm.io/package/@material/mwc-fab
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: