Skip to content

Ensure all <mwc-fab> set a label for ARIA#7587

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:mwc-fab-aria-labels
Nov 7, 2020
Merged

Ensure all <mwc-fab> set a label for ARIA#7587
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:mwc-fab-aria-labels

Conversation

@spacegaier
Copy link
Member

@spacegaier spacegaier commented Nov 3, 2020

Breaking change

Proposed change

<mwc-fab> uses the label attribute to set the aria-label for its included elements (= the actual button). This PR ensure that we set it for all <mwc-fab>.

https://npm.io/package/@material/mwc-fab

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Unlabeled buttons #3267
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

When you set a dynamic value (like a translation) use the property (with the .) to set it instead of the attribute.

@spacegaier
Copy link
Member Author

@adamjernst FYI: I combined your proposed changes from #7612 into this PR since I anyway touched basically all <mwc-fab> here already.

@adamjernst
Copy link
Contributor

@adamjernst FYI: I combined your proposed changes from #7612 into this PR since I anyway touched basically all <mwc-fab> here already.

Beautiful, thanks! I'll close my PRs as soon as this is merged.

@bramkragten bramkragten merged commit 33cd9bf into home-assistant:dev Nov 7, 2020
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Nov 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
@spacegaier spacegaier deleted the mwc-fab-aria-labels branch November 11, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants