Add a textual label to the "Add Integration" button#7604
Closed
adamjernst wants to merge 1 commit intohome-assistant:devfrom
Closed
Add a textual label to the "Add Integration" button#7604adamjernst wants to merge 1 commit intohome-assistant:devfrom
adamjernst wants to merge 1 commit intohome-assistant:devfrom
Conversation
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
bramkragten
reviewed
Nov 5, 2020
Member
|
Can you add a screenshot? Our design sketches include a change of the fab :-) |
adamjernst
force-pushed
the
integration-button
branch
from
840914e to
674b5dd
Compare
Contributor
Author
|
Nice! Glad I intuited the design direction ;)
Since a lot of the documentation references "button with a + symbol", I suggest we leave the icon intact for now. After a few months pass and everyone has upgraded, we can edit the documentation to refer to the new caption and drop the icon. |
bramkragten
reviewed
Nov 5, 2020
The Material "fab" (floating action button) to add a new integration is currently configured without a label. This leads to a lot of awkward documentation that refers to "the button with the + symbol". It also makes the button a relatively small and inconspicuous target. I would like to discuss the possibility of adding a textual label to it using the `extended` style for `mwc-fab`. I have tenatively chosen "Add" but I am open to other options. If this is approved, I am happy to send subsequent PRs for other similar buttons in the frontend.
adamjernst
force-pushed
the
integration-button
branch
from
674b5dd to
166d91f
Compare
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's one more place we can do that. This is especially important in my opinion since there are *two* "+" buttons on this screen - one to add a view, and one to add a card.
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that. This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
9 tasks
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that. This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that. This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that. This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
adamjernst
added a commit
to adamjernst/frontend
that referenced
this pull request
Nov 6, 2020
Similar to home-assistant#7604. It seems that the design sketches for Home Assistant include using labels for most floating action buttons... here's two more places we can do that. This is especially important for "Add Card" in my opinion since there are *two* "+" buttons on that screen - one to add a view, and one to add a card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Material "fab" (floating action button) to add a new integration is currently configured without a label.
This leads to a lot of awkward documentation that refers to "the button with the + symbol". It also makes the button a relatively small and inconspicuous target.
I would like to discuss the possibility of adding a textual label to it using the
extendedstyle formwc-fab. I have tenatively chosen "Add" but I am open to other options.If this is approved, I am happy to send subsequent PRs for other similar buttons in the frontend.
Proposed change
Add a textual label to the "add integration" floating action button.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: