Skip to content

Fix Firefox quick bar issue by allowing Ctrl+P to toggle modes #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 2 commits into from
Oct 21, 2020
Merged

Fix Firefox quick bar issue by allowing Ctrl+P to toggle modes #7413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e719d3
Hitting Ctrl+P when quick bar already open toggles mode
donkawechico Oct 21, 2020
ce215d3
Merge branch 'dev' into ctrl_p_toggles_mode
bramkragten Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/dialogs/quick-bar/ha-quick-bar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class QuickBar extends LitElement {
private _focusSet = false;

public async showDialog(params: QuickBarParams) {
this._commandMode = params.commandMode || false;
this._commandMode = params.commandMode || this._toggleIfAlreadyOpened();
this._commandItems = this._generateCommandItems();
this._entityItems = this._generateEntityItems();
this._opened = true;
Expand Down Expand Up @@ -305,6 +305,10 @@ export class QuickBar extends LitElement {
.sort((a, b) => compare(a.text.toLowerCase(), b.text.toLowerCase()));
}

private _toggleIfAlreadyOpened() {
return this._opened ? !this._commandMode : false;
}

private _setFilteredItems() {
const items = this._commandMode ? this._commandItems : this._entityItems;
this._items = this._filter
Expand Down