Skip to content

Allow breaking of entity ID in history tooltip into multiple lines#7482

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:history-tooltip-id-wrap
Oct 27, 2020
Merged

Allow breaking of entity ID in history tooltip into multiple lines#7482
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:history-tooltip-id-wrap

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

Long entity IDs current continue outside of the tooltip. Now they are wrapped.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@noxhirsch
Copy link
Contributor

The question is, if the entity_id is really needed to be shown in a Lovelace UI history-graph-card (if you want to see it, you can look it up in the edit mode). Especially with this line break, it looks really ugly ...

@spacegaier
Copy link
Member Author

Per the original implementation PR #7310 it is only shown for users in advanced mode which might be interested in it. But either way, this PR is just attempting to fix the overflow issue and not change the overall functionality.

@noxhirsch
Copy link
Contributor

You're right - wrong place to discuss that. Sorry!

@bramkragten bramkragten merged commit dbbd34c into home-assistant:dev Oct 27, 2020
@spacegaier spacegaier deleted the history-tooltip-id-wrap branch October 27, 2020 10:17
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants