Confirm when resetting hassio optoins#4718
Merged
Merged
Conversation
bramkragten
approved these changes
Feb 3, 2020
bramkragten
approved these changes
Feb 3, 2020
55c8715 to
aadd171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Confirm when resetting hass.io add-on options to default.
I've updated the confirm dialog API to return a promise that resolves into
true/false. That way it's a lot easier to use than passingcancel/confirm. TheconfirmAPI also felt weird, it has an optionaloutparameter? That seems like we merged a little too many types. Better keep them separate. I've simplified it a bit now, I think that we should aim to get rid of allcancelandconfirmoptions in the codebase and then just pass aresolve(from Promise) to the dialog box to collect the result withnullindicating a cancel.Fixes #3854
Fixes #4393
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: