Skip to content

Confirm when resetting hassio optoins#4718

Merged
balloob merged 1 commit into
devfrom
confirm-hassio-reset-options
Feb 3, 2020
Merged

Confirm when resetting hassio optoins#4718
balloob merged 1 commit into
devfrom
confirm-hassio-reset-options

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 1, 2020

Breaking change

Proposed change

Confirm when resetting hass.io add-on options to default.

I've updated the confirm dialog API to return a promise that resolves into true/false. That way it's a lot easier to use than passing cancel/confirm. The confirm API also felt weird, it has an optional out parameter? That seems like we merged a little too many types. Better keep them separate. I've simplified it a bit now, I think that we should aim to get rid of all cancel and confirm options in the codebase and then just pass a resolve (from Promise) to the dialog box to collect the result with null indicating a cancel.

Fixes #3854
Fixes #4393

Screen Shot 2020-01-31 at 23 04 54

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob force-pushed the confirm-hassio-reset-options branch from 55c8715 to aadd171 Compare February 3, 2020 16:35
@balloob balloob mentioned this pull request Feb 3, 2020
8 tasks
@balloob balloob merged commit 82ff444 into dev Feb 3, 2020
@delete-merged-branch delete-merged-branch Bot deleted the confirm-hassio-reset-options branch February 3, 2020 16:54
@lock lock Bot locked and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add confirmation prompt when resetting Hass.io add-on to defaults

3 participants