Skip to content

🔧 Standardize Generic Dialogs#4726

Merged
bramkragten merged 8 commits into
home-assistant:devfrom
timmo001:standardize-dialogs
Mar 9, 2020
Merged

🔧 Standardize Generic Dialogs#4726
bramkragten merged 8 commits into
home-assistant:devfrom
timmo001:standardize-dialogs

Conversation

@timmo001
Copy link
Copy Markdown
Member

@timmo001 timmo001 commented Feb 2, 2020

Proposed change

Swaps some more dialogs to use the generic dialog added in #4114

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@timmo001 timmo001 changed the title 🔧 Standardize Dialogs 🔧 Standardize Generic Dialogs Feb 2, 2020
@timmo001 timmo001 marked this pull request as ready for review February 2, 2020 13:42
@balloob
Copy link
Copy Markdown
Member

balloob commented Feb 3, 2020

FYI: In #4718 I am converting our dialogs to be able to use them with await too.

image

@bramkragten bramkragten merged commit 52160a3 into home-assistant:dev Mar 9, 2020
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants