WIP: Adds confirmation dialog to reset add-on configuration#4393
Closed
ludeeus wants to merge 5 commits into
Closed
WIP: Adds confirmation dialog to reset add-on configuration#4393ludeeus wants to merge 5 commits into
ludeeus wants to merge 5 commits into
Conversation
Member
Author
|
There are a few other places in the hassio panel that should have confirmations, reboot/restart for instance. |
Contributor
|
@ludeeus please remember about update button (when a new version on HA is available) |
Member
Author
Contributor
|
@ludeeus is there an option to show |
Member
Author
|
IMO that is out of the scope of this PR, this serves as the gateway to add a confirmation property to the api-call button. But I will keep it in mind when I start translations, and then add inn these so they reflect the users selected language. confirmBtnText: this.hass!.localize("ui.common.yes"),
cancelBtnText: this.hass!.localize("ui.common.no"),
``` |
bramkragten
reviewed
Jan 2, 2020
bramkragten
reviewed
Jan 2, 2020
bramkragten
reviewed
Jan 2, 2020
bramkragten
approved these changes
Jan 2, 2020
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
Member
Author
9 tasks
Member
Author
|
closed in favor of #4718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds:
ha-call-api-button(same asha-call-service-button)Reboot of #3945
Closes #3854
This time I have actually tested it 🙈
