Skip to content

WIP: Adds confirmation dialog to reset add-on configuration#4393

Closed
ludeeus wants to merge 5 commits into
home-assistant:devfrom
ludeeus:hassio-confirm
Closed

WIP: Adds confirmation dialog to reset add-on configuration#4393
ludeeus wants to merge 5 commits into
home-assistant:devfrom
ludeeus:hassio-confirm

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Dec 28, 2019

This adds:

Reboot of #3945
Closes #3854

This time I have actually tested it 🙈
image

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Dec 28, 2019

There are a few other places in the hassio panel that should have confirmations, reboot/restart for instance.
Should those be part of this PR or separate PRs at a later stage?

@Misiu
Copy link
Copy Markdown
Contributor

Misiu commented Dec 31, 2019

@ludeeus please remember about update button (when a new version on HA is available)
Also if possible please add localization.

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Dec 31, 2019

@Misiu That button is planed as well.
The same is localization, but before I start on that I want to be done with #4398

@Misiu
Copy link
Copy Markdown
Contributor

Misiu commented Jan 2, 2020

@ludeeus is there an option to show YES and CANCEL (or NO) instead of OK and CANCEL?
You are asking a question and the user should confirm by clicking YES.
What do you think?

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 2, 2020

IMO that is out of the scope of this PR, this serves as the gateway to add a confirmation property to the api-call button.

But I will keep it in mind when I start translations, and then add inn these so they reflect the users selected language.

confirmBtnText: this.hass!.localize("ui.common.yes"),
cancelBtnText: this.hass!.localize("ui.common.no"),
```

Comment thread src/components/buttons/ha-call-api-button.js Outdated
Comment thread src/components/buttons/ha-call-api-button.js Outdated
Comment thread src/components/buttons/ha-call-api-button.js Outdated
ludeeus and others added 3 commits January 2, 2020 16:02
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
@ludeeus ludeeus changed the title Adds confirmation dialog to reset add-on configuration WIP: Adds confirmation dialog to reset add-on configuration Jan 26, 2020
@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 26, 2020

With #4114 this now needs to be updated, should probably wait until #4398 is done.

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Feb 1, 2020

closed in favor of #4718

@ludeeus ludeeus closed this Feb 1, 2020
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add confirmation prompt when resetting Hass.io add-on to defaults

4 participants