Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display last changed in glance-card #3584

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

iantrich
Copy link
Member

@iantrich iantrich commented Sep 3, 2019

@bramkragten
Copy link
Member

Shouldn't this be an option on the entity instead of the card?

@iantrich
Copy link
Member Author

iantrich commented Sep 3, 2019

That's the direction I started but all such options are card level. Was going to bring that up outside of this.

@iantrich
Copy link
Member Author

iantrich commented Sep 3, 2019

@balloob @thomasloven input on moving show options of glance card to entity-level?
i.e.
show_icon
show_name
show_state
show_last_changed

@bramkragten
Copy link
Member

I can understand that show_icon, show_name, show_state are on card level as they change the layout. But show_last_changed doesn't, it affects what data is shown.

@iantrich
Copy link
Member Author

iantrich commented Sep 3, 2019

hmm, fair point

iantrich added a commit to home-assistant/home-assistant.io that referenced this pull request Sep 3, 2019
@bramkragten bramkragten merged commit 4f3abe1 into home-assistant:dev Sep 3, 2019
balloob pushed a commit to home-assistant/home-assistant.io that referenced this pull request Sep 4, 2019
@bramkragten bramkragten mentioned this pull request Sep 4, 2019
bramkragten added a commit that referenced this pull request Sep 4, 2019
* Alarm codes (#3566)

* Handle alarm codes from keyboard input

Closes #2602

* remove friendly_name changes

* remove unnecessary TS check

* Update azure-pipelines-release.yml for Azure Pipelines

* Don't remove `hvac_action` from history attributes (#3570)

So it can be used to plot a fill when active in the graph.

* Update the map when making config changes (#3568)

* Add haptic feedback to handle click (#3569)

* Filter camera service entities (#3583)

Closes #3582

* Notification drawer RTL support (#3580)

* add exceptional icon (#3572)

* Add options to badges (#3552)

* Add options to badges

name
icon
entity_picture

* lint

* lint

* rename entityPicture to image

* Align styling cast buttons (#3579)

* Align styling cast buttons

* Split dev constants

* Ignore dev_const

* Update README.md

* Move lovelace background settings to theme (#3561)

* Move lovelace background settings to theme

While being backwards compatible

* Also update cast

* Don't allow overwrite of english lang (#3590)

* Update hui-card-options.ts (#3591)

* Fix display of no triggers text if no device is selected or device has no triggers (#3592)

* Fix timing issue in external auth (#3587)

* Fix timing issue in external auth

* add await 0

* Show toast on successfull save (#3576)

* Show toast on successfull save

We need to make a list of places where this could benefit the user experience.

* Helper method

* Rename

* handle unavailable lights (#3549)

* handle unavailable lights

* unavailable overlay

* extract unavailable overlay

* Option to display last changed in glance-card (#3584)

* Option to display last changed in glance-card

Closes home-assistant/ui-schema#110

* move show_last_changed to entity-level

* address review comments

* Filter alerts in services (#3598)

Closes #3597

* Add exceptional in weather to translations (#3599)

* Add MQTT subscribe to dev tools (#3589)

* Add mqtt subscribe to dev tools

* Update mqtt-subscribe-card.ts

* Comments

* type

* Wrap long attributes in more-info-default (#3601)

Can likely be applied in many other places

Closes #2811

* Bumped version to 20190904.0 (#3612)
@bramkragten bramkragten mentioned this pull request Sep 8, 2019
@iantrich iantrich deleted the glance-last-changed branch September 9, 2019 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show last changed instead of state in glance cards
4 participants