Show toast on successfull save #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make a list of places where this could benefit the user experience.
balloob
reviewed
Sep 3, 2019
| @@ -150,6 +151,9 @@ class HaUserEditor extends LitElement { | |||
| await updateUser(this.hass!, this.user!.id, { | |||
| group_ids: [newGroup], | |||
| }); | |||
| showToast(this, { | |||
There was a problem hiding this comment.
Can we extract this into a helper method.
balloob
approved these changes
Sep 3, 2019
balloob
reviewed
Sep 3, 2019
| @@ -23,6 +23,7 @@ import { | |||
| SYSTEM_GROUP_ID_USER, | |||
| SYSTEM_GROUP_ID_ADMIN, | |||
| } from "../../../data/user"; | |||
| import { showSuccesToast } from "../../../util/toast-saved-success"; | |||
There was a problem hiding this comment.
Can we rename it to showSaveSuccessToast ? (also with double ss at end)
There was a problem hiding this comment.
All the names for auto complete are global, so I prefer having the name identify exactly what it does.
balloob
approved these changes
Sep 3, 2019
Merged
bramkragten
added a commit
that referenced
this pull request
Sep 4, 2019
* Alarm codes (#3566) * Handle alarm codes from keyboard input Closes #2602 * remove friendly_name changes * remove unnecessary TS check * Update azure-pipelines-release.yml for Azure Pipelines * Don't remove `hvac_action` from history attributes (#3570) So it can be used to plot a fill when active in the graph. * Update the map when making config changes (#3568) * Add haptic feedback to handle click (#3569) * Filter camera service entities (#3583) Closes #3582 * Notification drawer RTL support (#3580) * add exceptional icon (#3572) * Add options to badges (#3552) * Add options to badges name icon entity_picture * lint * lint * rename entityPicture to image * Align styling cast buttons (#3579) * Align styling cast buttons * Split dev constants * Ignore dev_const * Update README.md * Move lovelace background settings to theme (#3561) * Move lovelace background settings to theme While being backwards compatible * Also update cast * Don't allow overwrite of english lang (#3590) * Update hui-card-options.ts (#3591) * Fix display of no triggers text if no device is selected or device has no triggers (#3592) * Fix timing issue in external auth (#3587) * Fix timing issue in external auth * add await 0 * Show toast on successfull save (#3576) * Show toast on successfull save We need to make a list of places where this could benefit the user experience. * Helper method * Rename * handle unavailable lights (#3549) * handle unavailable lights * unavailable overlay * extract unavailable overlay * Option to display last changed in glance-card (#3584) * Option to display last changed in glance-card Closes home-assistant/ui-schema#110 * move show_last_changed to entity-level * address review comments * Filter alerts in services (#3598) Closes #3597 * Add exceptional in weather to translations (#3599) * Add MQTT subscribe to dev tools (#3589) * Add mqtt subscribe to dev tools * Update mqtt-subscribe-card.ts * Comments * type * Wrap long attributes in more-info-default (#3601) Can likely be applied in many other places Closes #2811 * Bumped version to 20190904.0 (#3612)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make a list of places where this could benefit the user experience.