Conversation
|
I'm not really up to date on how the media_player domain works, but what if the cover is served from a local network address? Maybe that's not even possible, in which case it's obviously not a problem? |
|
In that case the cover is not externally accessible and we fall back to the current behavior, which is to proxy it. See also the linked backend PR. |
|
Right, what is causing confusion here is that entity_picture is a relative link to the proxy url when the picture is not remotely accessible. |
|
So an entity_picture is either |
|
|
||
| // We have a new picture url | ||
| // If entity picture is non-relative, we use that url directly. | ||
| if (picture.substr(0, 1) !== "/") { |
There was a problem hiding this comment.
This seems kinda smelly... would it be better to add media_image_remotely_accessible to state attributes so we can key off that directly?
There was a problem hiding this comment.
I agree that it is a little fragile. This implementation is directly tied to how the media player is implemented. If album art is not externally accessible, we set it to a relative url that points at the media player album art proxy. (which sucks btw, because it means we change states every 30s for no good reason)
|
I have been thinking, adding a property is a bit weird too. Let's just ship it and 🚀 |
4 participants
Requires home-assistant/core#23337
When a media player has an external accessible cover, don't proxy the data through Home Assistant backend.