Merged
Conversation
homeassistant
added
cla-signed
core
has-tests
integration: media_player
small-pr
andrewsayre
reviewed
Apr 24, 2019
| if player.media_image_remotely_accessible: | ||
| url = player.media_image_url | ||
| if url is not None: | ||
| return web.Response(status=301, headers={ |
Member
There was a problem hiding this comment.
Do the parameters used in /api/media_player_proxy (token or cache) change whenever the media changes? If not, we should be using a 302 instead so browsers don't cache the redirect and pin to the image.
andrewsayre
approved these changes
Apr 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Allow integrations to indicate that their cover urls can be accessed externally, indicating to the frontend that we don't have to proxy the image.
When property set to True, the entity_picture will default to just that url.
To do:
Related issue (if applicable): fixes home-assistant/architecture#211
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: