Skip to content

Don't proxy external accessible covers #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Apr 25, 2019
Merged

Don't proxy external accessible covers #3120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cards/ha-media_player-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,14 @@ class HaMediaPlayerCard extends LocalizeMixin(EventsMixin(PolymerElement)) {
}

// We have a new picture url
// If entity picture is non-relative, we use that url directly.
if (picture.substr(0, 1) !== "/") {
Copy link
Copy Markdown
Member

@andrewsayre andrewsayre Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems kinda smelly... would it be better to add media_image_remotely_accessible to state attributes so we can key off that directly?

Copy link
Copy Markdown
Member Author

@balloob balloob Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it is a little fragile. This implementation is directly tied to how the media player is implemented. If album art is not externally accessible, we set it to a relative url that points at the media player album art proxy. (which sucks btw, because it means we change states every 30s for no good reason)

this._coverShowing = true;
this._coverLoadError = false;
this.$.cover.style.backgroundImage = `url(${picture})`;
return;
}

try {
const {
content_type: contentType,
Expand Down