Skip to content

Add live streaming logbook websocket endpoint#72258

Merged
bdraco merged 49 commits intohome-assistant:devfrom
bdraco:logbook_streaming
May 22, 2022
Merged

Add live streaming logbook websocket endpoint#72258
bdraco merged 49 commits intohome-assistant:devfrom
bdraco:logbook_streaming

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 21, 2022

Frontend: home-assistant/frontend#12744

Proposed change

Add streaming logbook websocket endpoint

There are no changes to rest_api. Its a relocation only

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (websocket_api) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 21, 2022

Screen_Shot_2022-05-21_at_17_51_47

Performance testing looks good on rejecting state we don't want to render when the state machine is being flooded with power sensors

@bdraco bdraco marked this pull request as ready for review May 21, 2022 23:35
@bdraco bdraco requested a review from a team as a code owner May 21, 2022 23:35
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very impressive 🙇

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 22, 2022

Another round of testing, and this all still looks good.

The localization needs to be cleaned up a bit more to support home-assistant/frontend#12742 but thats for another PR

@bdraco bdraco merged commit 9c3f949 into home-assistant:dev May 22, 2022
@bdraco bdraco deleted the logbook_streaming branch May 22, 2022 19:57
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants