Always pass the source of the trigger for logbook context messages#72333
Merged
bdraco merged 5 commits intohome-assistant:devfrom May 23, 2022
Merged
Always pass the source of the trigger for logbook context messages#72333bdraco merged 5 commits intohome-assistant:devfrom
bdraco merged 5 commits intohome-assistant:devfrom
Conversation
9 tasks
Kane610
approved these changes
May 22, 2022
Member
Kane610
left a comment
There was a problem hiding this comment.
Looks good for deCONZ integration.
bdraco
commented
May 22, 2022
bdraco
commented
May 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend home-assistant/frontend#12742
Proposed change
We only passed the source of the trigger in the original message. The trigger source was missing from the context message which meant we always used the message which is nearly impossible to localize.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: