Skip to content

Always pass the source of the trigger for logbook context messages#72333

Merged
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:logbook_source
May 23, 2022
Merged

Always pass the source of the trigger for logbook context messages#72333
bdraco merged 5 commits intohome-assistant:devfrom
bdraco:logbook_source

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 22, 2022

Frontend home-assistant/frontend#12742

Proposed change

We only passed the source of the trigger in the original message. The trigger source was missing from the context message which meant we always used the message which is nearly impossible to localize.

  • Use logbook constants in all the logbook platform to ensure they all return consistent data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for deCONZ integration.

Copy link
Copy Markdown
Contributor

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdraco bdraco merged commit 0248a87 into home-assistant:dev May 23, 2022
@bdraco bdraco deleted the logbook_source branch May 23, 2022 18:35
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants