Add additional context data to logbook events#71721
Merged
balloob merged 15 commits intohome-assistant:devfrom May 13, 2022
Merged
Add additional context data to logbook events#71721balloob merged 15 commits intohome-assistant:devfrom
balloob merged 15 commits intohome-assistant:devfrom
Conversation
probot-home-assistant
bot
added
core
has-tests
integration: automation
integration: logbook
new-feature
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
9 tasks
bdraco
commented
May 12, 2022
bdraco
commented
May 12, 2022
bdraco
commented
May 12, 2022
Its confusing to have `was fired. caused by OTHER` when there is an event chain
bdraco
commented
May 12, 2022
bdraco
requested review from
a team,
Kane610,
balloob,
bieniu,
chemelli74 and
thecode
as code owners
balloob
reviewed
May 13, 2022
| message.hass = hass | ||
| message = message.async_render(parse_result=False) | ||
| async_log_entry(hass, name, message, domain, entity_id) | ||
| async_log_entry(hass, name, message, domain, entity_id, service.context) |
balloob
reviewed
May 13, 2022
|
|
||
|
|
||
| @callback | ||
| def async_describe_events( |
Member
There was a problem hiding this comment.
Good catch that we can move this here.
balloob
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend home-assistant/frontend#12667
Proposed change
Add additional context data to logbook events by removing the guards that prevented context data from being added to anything that wasn't a state_changed event (
if not entity_id). Most of the special cases are gone so this is no longer needed. Additionally theEVENT_HOMEASSISTANT_STARTandEVENT_HOMEASSISTANT_STOPevents no longer need to be special cases to they have been moved to an integration platform.Drops the
has beenfrom trigger messages as it doesn't mesh well:Before:
Put Master Bed TV Lift Upstarted from automationMaster Bed Harmony is Switch Off for 25 secondshas been triggered by state ofWatching TV in Master BedroomAfter:
Put Master Bed TV Lift Upstarted from automationMaster Bed Harmony is Switch Off for 25 secondstriggered by state ofWatching TV in Master BedroomType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: