Reduce logbook websocket payload size and parse json attributes via the DBM#71895
Merged
balloob merged 9 commits intohome-assistant:devfrom May 16, 2022
Conversation
Breaking: - The entity name is now always shown with the current name instead of the old name if it was renamed. If the entity no longer exists we now show the original entity_id instead Requires home-assistant/frontend#12667 - The name of the entity is no longer sent, and the current name in the state machine is now used - We no longer parse attributes in python. This task is offloaded to the database since we only need it for the icon.
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
commented
May 15, 2022
bdraco
commented
May 15, 2022
balloob
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires home-assistant/frontend#12667
Breaking change
current name instead of the old name if it
was renamed. If the entity no longer exists
we now show the original entity_id instead which
aligns with the warning icon we already display on
the frontend when a state is missing or removed.
Proposed change
The name of the entity is no longer sent to the websocket
api. Not a breaking change since the websocket api is new
in 2022.6
We no longer parse attributes in python. This
task is offloaded to the database since we only
need it for the icon.
JSONtype is supported on the DBMs we supported since 2015 (and 2016 for MSSQL but thats not supported)MySQL 5.7+ ~2015 https://docs.sqlalchemy.org/en/14/dialects/mysql.html?highlight=json#sqlalchemy.dialects.mysql.JSON
SQLite 3.9+ ~2015 https://docs.sqlalchemy.org/en/14/dialects/sqlite.html#sqlalchemy.dialects.sqlite.JSON
MSSQL 2016+ https://docs.sqlalchemy.org/en/14/dialects/mssql.html#sqlalchemy.dialects.mssql.JSON
PostgreSQL 9.2+ ~2012 https://www.postgresql.org/docs/9.2/datatype-json.html
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: