Skip to content

Use has_template property from lib in Fritz!SmartHome#89152

Merged
mib1185 merged 1 commit into
home-assistant:devfrom
mib1185:fritzbox/use-has_template-from-lib
Mar 21, 2023
Merged

Use has_template property from lib in Fritz!SmartHome#89152
mib1185 merged 1 commit into
home-assistant:devfrom
mib1185:fritzbox/use-has_template-from-lib

Conversation

@mib1185
Copy link
Copy Markdown
Member

@mib1185 mib1185 commented Mar 4, 2023

Proposed change

Check was implemented to fix #83555, but is now available directly from the lib (hthiery/python-fritzhome#72)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 4, 2023

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 force-pushed the fritzbox/use-has_template-from-lib branch from 896683b to 6be10dc Compare March 8, 2023 17:25
@mib1185 mib1185 marked this pull request as ready for review March 8, 2023 17:27
Copy link
Copy Markdown
Contributor

@flabbamann flabbamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mib1185 👍

@mib1185 mib1185 enabled auto-merge (squash) March 8, 2023 20:13
Comment thread homeassistant/components/fritzbox/__init__.py
@crasu crasu mentioned this pull request Mar 11, 2023
20 tasks
@mib1185 mib1185 added the smash Indicator this PR is close to finish for merging or closing label Mar 18, 2023
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mib1185 mib1185 merged commit d4cc4a3 into home-assistant:dev Mar 21, 2023
@mib1185 mib1185 deleted the fritzbox/use-has_template-from-lib branch March 22, 2023 07:49
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed code-quality has-tests integration: fritzbox Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to 2022.12 breaks Fritzbox integration

4 participants