Skip to content

Add window open mode for fritz climate#89541

Closed
crasu wants to merge 1 commit into
home-assistant:devfrom
crasu:feature/add_sleep_and_boost_mode_for_fritzbox_climate
Closed

Add window open mode for fritz climate#89541
crasu wants to merge 1 commit into
home-assistant:devfrom
crasu:feature/add_sleep_and_boost_mode_for_fritzbox_climate

Conversation

@crasu
Copy link
Copy Markdown

@crasu crasu commented Mar 11, 2023 •
edited
Loading

Proposed change

This enables setting window open mode for fritz home via home assistant.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

  • I have reviewed two other in this repository.

Yes: See #89150, #89152

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 11, 2023

Hey there @mib1185, @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@crasu crasu force-pushed the feature/add_sleep_and_boost_mode_for_fritzbox_climate branch from 927d715 to 36c81a1 Compare March 11, 2023 11:04
@crasu crasu marked this pull request as ready for review March 11, 2023 11:31
@crasu crasu requested a review from mib1185 as a code owner March 11, 2023 11:31
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 1, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Aug 1, 2023
@edenhaus edenhaus force-pushed the feature/add_sleep_and_boost_mode_for_fritzbox_climate branch from c30e209 to aa4ea23 Compare August 7, 2023 09:52
edenhaus
edenhaus requested changes Aug 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check/fix the CI

Comment thread homeassistant/components/fritzbox/climate.py
async def async_set_window_open(self, window_open: bool) -> None:
"""Set the thermostate to off (window open) for a pre defined time."""
if window_open:
timeout = 60 * 15
Copy link
Copy Markdown
Member

@edenhaus edenhaus Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the 15minutes coming?
Why do we not make it configurable?

@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Aug 7, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant Bot marked this pull request as draft August 7, 2023 10:04
@github-actions github-actions Bot removed the stale label Aug 7, 2023
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 6, 2023

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

@frenck frenck closed this Oct 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@edenhaus edenhaus edenhaus requested changes

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@mib1185 mib1185

Labels

cla-signed has-tests integration: fritzbox new-feature Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crasu @frenck @edenhaus @mib1185