Use matrix for db recorder tests#87640
Conversation
I do not agree with the stance in this PR. It is skipped, did not actually run. Making it look like it ran gives the wrong expectation / sends the wrong message. I don't like skipped jobs either (I wish we could just not show them), but just marking them as passed is not right either. |
I think I have found a solution, using a matrix.
|
|
As s bonus, this new flavour would enable the ability to test different versions of postgre and/or mariadb. |
|
I'll take a look tomorrow, but the coverage should get uploaded |
The reason I removed from |
| HA_SHORT_VERSION: 2023.3 | ||
| DEFAULT_PYTHON: "3.10" | ||
| ALL_PYTHON_VERSIONS: "['3.10']" | ||
| MARIADB_VERSIONS: "['mariadb:10.9.3']" |
There was a problem hiding this comment.
Unrelated to this PR but we should probably be testing with 10.6.10 since that is what ships with the addon
There was a problem hiding this comment.
👍
We can do that in a follow-up PR
|
@frenck any last comments before I merge? |
|
@epenet Sorry, no, I don't think so :) My main issue with the proposition seems to be addressed, so happy 👍 |
Proposed change
Should resolve

Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: