Skip to content

Align postgresql with mariadb in CI#87646

Merged
epenet merged 1 commit into
home-assistant:devfrom
epenet:postgresql
Feb 7, 2023
Merged

Align postgresql with mariadb in CI#87646
epenet merged 1 commit into
home-assistant:devfrom
epenet:postgresql

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Feb 7, 2023

Proposed change

I think that #87640 would be a better solution though...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Feb 7, 2023
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Feb 7, 2023

Thanks for the quick approval @bdraco
But I do think #87640 is a better solution long term.

(note: I can rebase #87640 later if we want to merge this one quickly)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Feb 7, 2023

I suggest merging this now and rebasing the other one

@epenet epenet merged commit 3e09950 into home-assistant:dev Feb 7, 2023
@epenet epenet deleted the postgresql branch February 7, 2023 17:27
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants