Google Assistant SDK integration#82328
Conversation
|
Not forgotten. I've just not gotten around to testing this. |
allenporter
left a comment
There was a problem hiding this comment.
So this is using notify as the first platform.. From my impression of the docs you added, it seems like this can really represent anything that google assistant do (e.g. theoretically, it could expose a lock since you can tell google assistant to unlock your lock). Am I understanding that right?
|
Yes your understanding is right. I've personally been using this mostly for the broadcast announcements, controlling nest guard and playing relaxing sounds in bedroom speakers in a schedule. |
This is to improve diff of the next commit with the actual implementation. Commands used: cp -r homeassistant/components/google_sheets/ homeassistant/components/google_assistant_sdk/ cp -r tests/components/google_sheets/ tests/components/google_assistant_sdk/ find homeassistant/components/google_assistant_sdk/ tests/components/google_assistant_sdk/ -type f | xargs sed -i \ -e 's@google_sheets@google_assistant_sdk@g' \ -e 's@Google Sheets@Google Assistant SDK@g' \ -e 's@tkdrob@tronikos@g'
Allows sending commands and broadcast messages to Google Assistant.
ea18b91 to
75da4b2
Compare
|
Looks good to merge after CI passes |
|
Looks like there is a protobuf 4 conflict. My impression was that just a few weeks ago were using protobuf 3 as some proejcts were not ready for the proto4 compiler yet (this was blocking a grpc upgrade) but it looks like that has been resolved. |
|
The problem is the underlying library depends on outdated google-assistant-grpc==0.3.0 which causes the following error when using protobuf 4: I'll have to check if I can stop depending on google-assistant-grpc and instead include https://github.com/googleapis/googleapis/blob/master/google/assistant/embedded/v1alpha2/embedded_assistant.proto in the library and generate the _pb2.py using the latest protoc. |
Makes sense. That project looks like it has hardly any activity (unclear if its worth upgrading it to protobuf 4) |
|
PTAL. I believe I fixed the protobuf conflict. gassist-text library now works with either protobuf 3 or 4. |
|
@tronikos I was reviewing the delta in the python library tronikos/gassist_text@0.0.2...0.0.4 and saw the build and setup were removed. Do you have an approach to bring that back? Generally, as you improve |
|
I migrated the setup to using pyproject.toml, which is now the preferred
way, to avoid a warning using the deprecated setup.py.
|
|
And for publishing the package I use a GitHub action so you should be able
to easily see how the library is build.
|
|
Thank you, I missed the toml addition. |
Proposed change
Allow sending commands and broadcast messages to Google Assistant.
Requirements for this to work:
Type of change
Additional information
This is an alternative approach to #82188
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: