Skip to content

Add logo and icon for the google_assistant_sdk integration#3865

Merged
frenck merged 2 commits into
home-assistant:masterfrom
tronikos:master
Dec 28, 2022
Merged

Add logo and icon for the google_assistant_sdk integration#3865
frenck merged 2 commits into
home-assistant:masterfrom
tronikos:master

Conversation

@tronikos
Copy link
Copy Markdown
Member

@tronikos tronikos commented Nov 18, 2022

Proposed change

Needed for home-assistant/core#82328

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@tronikos tronikos changed the title Create google_assistant_sdk Add logo and icon for google_assistant_sdk integration Nov 18, 2022
@tronikos tronikos changed the title Add logo and icon for google_assistant_sdk integration Add logo and icon for the google_assistant_sdk integration Nov 18, 2022
@tronikos tronikos mentioned this pull request Nov 20, 2022
Merged
8 tasks
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Nov 20, 2022
frenck
frenck approved these changes Nov 20, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Nov 20, 2022
@tronikos
Copy link
Copy Markdown
Member Author

tronikos commented Dec 17, 2022

Parent PR was merged a while ago. Should this automatically merge?

@frenck frenck added the parent-merged The parent PR has been merged already label Dec 19, 2022
@tronikos
Copy link
Copy Markdown
Member Author

tronikos commented Dec 27, 2022

Can this be merged? The logo is missing from the rc documentation:
https://rc.home-assistant.io/integrations/#search/Google%20assistant

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 27, 2022

@tronikos Have patience; merging this will not instantly fix RC docs. The PR is labeled correctly.

@frenck frenck merged commit c2d26ba into home-assistant:master Dec 28, 2022
tsunglung pushed a commit to tsunglung/brands that referenced this pull request Sep 22, 2023
@tronikos
Add logo and icon for the google_assistant_sdk integration (home-assi…
5d5da27 
…stant#3865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck approved these changes

Assignees

No one assigned

Labels

awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tronikos @frenck