Google Sheets: small cleanup#83685
Conversation
This is not needed. This was copied from google calendar integration where it was needed to reauth when the scope changed.
|
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@allenporter PTAL. I removed the async_entry_has_scopes check per your comment in #82328 along with some other small code improvements. |
|
Should I revert 63e24f8 commit and keep the other 5 commits? |
|
Let's see what Allen says. I could just add back the other pieces needed during a merge commit. |
|
I'm fine with leaving given you're about to use it 👍🏼 On the reauth text change: I think reauth will still happen if creds are invalid as the config entry is setup. Do the reauth strings and steps need to stay? |
This reverts commit 63e24f8.
|
I reverted "Remove async_entry_has_scopes check" commit. Allen, my changes in strings.json remove a duplicate object key. |
Proposed change
Small cleanup in Google Sheets integration
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: