Skip to content

Migrate Nuki to new entity naming style#80021

Merged
MartinHjelmare merged 3 commits into
home-assistant:devfrom
Nardol:nuki/new_naming_style
Jan 26, 2023
Merged

Migrate Nuki to new entity naming style#80021
MartinHjelmare merged 3 commits into
home-assistant:devfrom
Nardol:nuki/new_naming_style

Conversation

@Nardol
Copy link
Copy Markdown
Contributor

@Nardol Nardol commented Oct 10, 2022

Proposed change

Migrate the Nuki integration to new naming style
Without setting names the lock is called as the device and the door sensor is named Device name Doorsensor.
Names are not documented.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
@homeassistant
Copy link
Copy Markdown
Contributor

Hey there @pschmitt, @pvizeli, @pree, mind taking a look at this pull request as it has been labeled with an integration (nuki) you are listed as a code owner for? Thanks!

Copy link
Copy Markdown
Member

@pree pree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for this to work properly the nuki integration needs to register the devices first. I've opened a PR for this a couple of days ago: #79806

Comment thread homeassistant/components/nuki/lock.py
Comment thread homeassistant/components/nuki/binary_sensor.py Outdated
Signed-off-by: Patrick ZAJDA <patrick@zajda.fr>
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 21, 2022
@MartinHjelmare MartinHjelmare added this to the 2023.2.0 milestone Jan 26, 2023
@MartinHjelmare MartinHjelmare merged commit 2e70de9 into home-assistant:dev Jan 26, 2023
@Nardol Nardol deleted the nuki/new_naming_style branch January 26, 2023 12:51
balloob pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Pascal Vizeli <pvizeli@syshack.ch>
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed code-quality Hacktoberfest hacktoberfest-accepted integration: nuki small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants