Add device registration to the Nuki component#79806
Conversation
|
Hey there @pschmitt, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Anything missing for this PR to be reviewed? |
|
Also the fact this PR is not being reviewed prevents the Nuki integration to have new entity naming style (#80021 ) |
|
@pree can you rebase it, so I can merge it? |
pree
force-pushed
the
feat/nuki/device-registration
branch
from
d1ec591 to
577510e
Compare
|
@pvizeli rebased |
| update_method=async_update_data, | ||
| # Polling interval. Will only be polled if there are subscribers. | ||
| update_interval=UPDATE_INTERVAL, | ||
| # Device registration for the bridge |
There was a problem hiding this comment.
A bridge (the 3.0 which is in sell now long time) can have more than 1 lock device. Does that still work?
There was a problem hiding this comment.
Mine has a lock + opener connected, that works. I guess the limitation here is that the integration can only connect to a single bridge, but since the integration can be created multiple times I don't see this as an issue.
There was a problem hiding this comment.
I've just tried it with a mock API to have one opener and two locks, works flawlessly for me
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comment in a new PR. Thanks!
* Add device registration to the Nuki component * Name is always given by the API * implement pvizeli's suggestions * switch device_registry to snake_case * fix entity naming * unify manufacturer names
7 participants
Proposed change
Introduces device registrations for the Nuki entities, including the bridge.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: