Skip to content

Migrate Nuki to new entity naming style #80021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 3 commits into from
Jan 26, 2023
+3 −0
Merged

Migrate Nuki to new entity naming style #80021

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f03e13
Migrate Nuki to new entity naming style
Nardol Oct 10, 2022
5448bb1
Add name to binary sensor
Nardol Oct 10, 2022
3d953cf
Merge branch 'dev' into nuki/new_naming_style
pvizeli Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions homeassistant/components/nuki/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,10 @@ async def async_setup_entry(
class NukiDoorsensorEntity(NukiEntity, BinarySensorEntity):
"""Representation of a Nuki Lock Doorsensor."""

_attr_has_entity_name = True
_attr_name = "Door sensor"
_attr_device_class = BinarySensorDeviceClass.DOOR

@property
def name(self):
"""Return the name of the lock."""
return self._nuki_device.name
Comment thread
Nardol marked this conversation as resolved.
Outdated

@property
def unique_id(self) -> str:
"""Return a unique ID."""
Expand Down
6 changes: 1 addition & 5 deletions homeassistant/components/nuki/lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,9 @@ async def async_setup_entry(
class NukiDeviceEntity(NukiEntity, LockEntity, ABC):
"""Representation of a Nuki device."""

_attr_has_entity_name = True
Comment thread
Nardol marked this conversation as resolved.
_attr_supported_features = LockEntityFeature.OPEN

@property
def name(self) -> str | None:
"""Return the name of the lock."""
return self._nuki_device.name

@property
def unique_id(self) -> str | None:
"""Return a unique ID."""
Expand Down