Rachio update#7922
Conversation
This makes LIFX Gen3 lights work with the current firmware.
|
Please create a new branch instead of reusing your old branch. |
| DEFAULT_MANUAL_RUN_MINS = 10 | ||
|
|
||
| MIN_UPDATE_INTERVAL = timedelta(minutes=5) | ||
| MIN_UPDATE_INTERVAL = timedelta(seconds=5) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Rachio offers an API for free but hitting it every 5 seconds is going to get us banned.
There was a problem hiding this comment.
@balloob, I've been running mine with a 30 second interval and it seems to have the same desired effect, in that regardless of 5 or 30 seconds it updates the correct state on the frontend after about 30 seconds have passed. Do you think leaving timedelta at 30 seconds would be acceptable to not overload the API?
|
|
||
|
|
||
| # noinspection PyUnusedLocal | ||
| # noinspection PyUnresolvedLocal |
There was a problem hiding this comment.
Please remove these warnings. They are not part of linters that the project uses.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't understand this comment.
* Additional demo fan with only speed support * Update demo fan tests
* add mailgun component * add to coveragerc
…ipt (#7928) * fixing potential null issue with optional param being parsed as a script * Create template.py
* Add Flexit AC climate platform * Protocol extracted to third party lib
|
Please base your changes off a new copy of the dev branch. It now includes a lot of commits that are not part of this changeset. |
* - Simple keyword to action config * - Added more fuzzy stuff * - Logging & a bit of commenting * - pep8? * - pep8 and quick formatting fixes * - Changed configuration a bit * - Backwards compatibility tests * - Fallback or * - Added custom configuration for conversation * - Moved imports inside function * - pep8 * - Pass tests better * - Removed unused imports * - Moved warning ignore to above import for fuzzy * - Moved return for consistent return types * - Fallback if no choices to listen for * - Fixed linting errors * - Better logging and fixed linting errors(?) * - Fixed continuation * - Added one blank line after class docstring * Create conversation.py * Create test_conversation.py * Create test_conversation.py * Update test_conversation.py
* entity id is optional * use a simple if/else to set the data for the fan.turn_off service
| """Stop all zones.""" | ||
| _LOGGER.info("Stopping watering of all zones") | ||
| self.rachio.device.stopWater(self._device.device_id) | ||
| self.rachio.device.stopWater(self._device.device_id) No newline at end of file |
|
Please create a new PR based off a new branch forked off our dev branch. |
ghost
added
19 participants
Description:
Update to #7600
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.