Skip to content

Do not call update() in constructor#7917

Merged
fabaff merged 1 commit into
home-assistant:devfrom
fabaff:update-constructor
Jun 5, 2017
Merged

Do not call update() in constructor#7917
fabaff merged 1 commit into
home-assistant:devfrom
fabaff:update-constructor

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Jun 5, 2017

Description:

Do not call update() in constructor.

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: yahoo_finance
    symbols:
      - RHT
      - GOOGL
      - FAAFD
  - platform: hddtemp
    host: localhost

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link
Copy Markdown

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nkgilley, @colinodell and @ttroy50 to be potential reviewers.

@fabaff fabaff merged commit 760138a into home-assistant:dev Jun 5, 2017
@fabaff fabaff deleted the update-constructor branch June 5, 2017 19:28
@fabaff fabaff mentioned this pull request Jun 6, 2017
1 task
fabaff added a commit that referenced this pull request Jun 6, 2017
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants