Skip to content

Fixing Client connection error#7991

Merged
balloob merged 1 commit into
home-assistant:devfrom
sander76:dev
Jun 12, 2017
Merged

Fixing Client connection error#7991
balloob merged 1 commit into
home-assistant:devfrom
sander76:dev

Conversation

@sander76
Copy link
Copy Markdown
Contributor

@sander76 sander76 commented Jun 10, 2017

Description:

During long polling, when a "Client connect error" occurred (for example by an async timeout) the return value seemed to block the flow unable to recover and completely disable the telegram_bot.

This fix should let the "Client connect error" occur, but allow for recovery of the bot.

Related issue (if applicable): fixes #
#7328
#7938

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@sander76, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @azogue and @pvizeli to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jun 12, 2017

Thanks

@balloob balloob merged commit 1c06b51 into home-assistant:dev Jun 12, 2017
@balloob balloob mentioned this pull request Jun 16, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants