Skip to content

switch.tplink: upgrade to the newest upstream release which adds supp…#6979

Merged
balloob merged 1 commit into
home-assistant:devfrom
rytilahti:update_pyhs100
Apr 8, 2017
Merged

switch.tplink: upgrade to the newest upstream release which adds supp…#6979
balloob merged 1 commit into
home-assistant:devfrom
rytilahti:update_pyhs100

Conversation

@rytilahti
Copy link
Copy Markdown
Member

…ort for plugs using the newer communication protocol

Description:

pyhs100 depends on future package for py2 support, which was not explicitly stated in the setup.py causing problems with users on such setups where it was not installed as a dependency for other components. The new upstream release fixes this by requiring the installation of future.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

…ort for plugs using the newer communication protocol
@mention-bot
Copy link
Copy Markdown

@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kirichkov, @miniconfig and @fabaff to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2017

Home Assistant only runs on Python 3 so anything that is only needed for Py2 support doesn't matter.

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2017

Anyway, looks good 🐬 thanks

@balloob balloob merged commit 55077b9 into home-assistant:dev Apr 8, 2017
@balloob balloob modified the milestone: 0.42 Apr 8, 2017
@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2017

Wait, this was a duplicate of #6790 ? I don't get it.

@rytilahti
Copy link
Copy Markdown
Member Author

rytilahti commented Apr 8, 2017

Thanks for merging, it's not a duplicate, the previous #6790 upgrades to 0.2.4.1 and this to 0.2.4.2. :)

edit: I oversaw that the previous one wasn't yet merged yesterday, could have indeed just updated that one..

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 8, 2017

This one actually doesn't upgrade to 0.2.4.2, it still shows 0.2.4.1 for me in changed tab

@rytilahti
Copy link
Copy Markdown
Member Author

Uhuh, weird. I don't know what happened here, this is indeed a duplicate which makes no sense?! I created a new PR: #6986

@rytilahti rytilahti deleted the update_pyhs100 branch April 8, 2017 15:11
@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants