Skip to content

switch.tplink: bump pyhs100 version requirement#6986

Merged
balloob merged 1 commit into
home-assistant:devfrom
rytilahti:pyhs100_update
Apr 8, 2017
Merged

switch.tplink: bump pyhs100 version requirement#6986
balloob merged 1 commit into
home-assistant:devfrom
rytilahti:pyhs100_update

Conversation

@rytilahti
Copy link
Copy Markdown
Member

Description:

pyhs100 depends on future package for py2 support, which was not explicitly stated in the setup.py causing problems with users on such setups where it was not installed as a dependency for other components. The new upstream release fixes this by requiring the installation of future.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link
Copy Markdown

@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kirichkov, @balloob and @fabaff to be potential reviewers.

@balloob balloob added this to the 0.42 milestone Apr 8, 2017
@balloob balloob merged commit 475ac52 into home-assistant:dev Apr 8, 2017
@rytilahti rytilahti deleted the pyhs100_update branch April 8, 2017 13:33
@fabaff fabaff mentioned this pull request Apr 8, 2017
@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants