Skip to content

switch.tplink: upgrade to the newest upstream release which adds supp…#6790

Merged
fabaff merged 1 commit into
home-assistant:devfrom
rytilahti:update_pyhs100
Mar 26, 2017
Merged

switch.tplink: upgrade to the newest upstream release which adds supp…#6790
fabaff merged 1 commit into
home-assistant:devfrom
rytilahti:update_pyhs100

Conversation

@rytilahti
Copy link
Copy Markdown
Member

@rytilahti rytilahti commented Mar 26, 2017

…ort for plugs using the newer communication protocol

Description:

This updates the switch.tplink to depend on the newest release, which adds support for HS105 plugs.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2335

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

…ort for plugs using the newer communication protocol
@mention-bot
Copy link
Copy Markdown

@rytilahti, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kirichkov, @scipioni and @fabaff to be potential reviewers.

Copy link
Copy Markdown
Contributor

@kirichkov kirichkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I hope this makes it in 0.41.

Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff merged commit f5d4f85 into home-assistant:dev Mar 26, 2017
@rytilahti rytilahti deleted the update_pyhs100 branch March 29, 2017 20:59
@fabaff fabaff mentioned this pull request Apr 6, 2017
@rytilahti rytilahti restored the update_pyhs100 branch April 8, 2017 00:03
@rytilahti rytilahti deleted the update_pyhs100 branch April 8, 2017 15:11
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants