Skip to content

Add EntityFeature enum to Light#69103

Merged
balloob merged 2 commits intodevfrom
frenck-2022-0816
Apr 3, 2022
Merged

Add EntityFeature enum to Light#69103
balloob merged 2 commits intodevfrom
frenck-2022-0816

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 1, 2022

Breaking change

Developers only: The use of the following constants has been deprecated:

  • SUPPORT_EFFECT
  • SUPPORT_FLASH
  • SUPPORT_TRANSITION

Use the new LightEntityFeature IntEnum instead.

Note that the following constants were already deprecated, thus LightEntityFeature does not provide a replacement for those.

  • SUPPORT_BRIGHTNESS
  • SUPPORT_COLOR_TEMP
  • SUPPORT_COLOR
  • SUPPORT_WHITE_VALUE

These cases should instead be migrated to the new color modes.

Proposed change

This PR introduces the FanEntityFeature, containing all the supported feature flags of a Fan.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob merged commit ea148a1 into dev Apr 3, 2022
@balloob balloob deleted the frenck-2022-0816 branch April 3, 2022 03:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants